feat: keyloader interopable with near-cli #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 25, 2023 18:15
ghost
marked this pull request as ready for review
|
@shariffdev Using system keychain is not going to work on CI, and also not very productive locally, and the original issue #196 probably suggested to use a folder with plain-text keys stored on disk, which is how near-cli JS does it. I am hesitant to support that as it promotes bad practices. Let me elaborate more on the issue itself. |
|
P.S. the "keystore" referred in near-cli is called "legacy keystore" in near-cli-rs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #196
It helps load keys saved using the
near-clicross-platform keychain, can also just used to set and get account credentials from keychain.Using
unstablefeature flag, it offers interoperability withnear-cliwhich is not yet v1.